Skip to content

Require explicit allowlist in IdentityServerDescriptorProvider to prevent SSRF - #55

Open
dujinhui wants to merge 1 commit into
google:masterfrom
dujinhui:fix-ssrf-untrusted-key-discovery
Open

Require explicit allowlist in IdentityServerDescriptorProvider to prevent SSRF#55
dujinhui wants to merge 1 commit into
google:masterfrom
dujinhui:fix-ssrf-untrusted-key-discovery

Conversation

@dujinhui

@dujinhui dujinhui commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator
  • Require explicit allowlisted issuers in IdentityServerDescriptorProvider constructor.
  • Reject unlisted, empty, or null issuers in getServerDescriptor.
  • Add null check in DefaultPublicKeyLocator.
  • Update test suites and add unit tests for allowlisting behavior.

…vent SSRF

- Require explicit allowlisted issuers in IdentityServerDescriptorProvider constructor.
- Reject unlisted, empty, or null issuers in getServerDescriptor.
- Add null check in DefaultPublicKeyLocator.
- Update test suites and add unit tests for allowlisting behavior.

@theorangepotato theorangepotato left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants