[protocol] Convert jtag to use the new compact error format - #291
Open
esnguyen wants to merge 1 commit into
Open
[protocol] Convert jtag to use the new compact error format#291esnguyen wants to merge 1 commit into
esnguyen wants to merge 1 commit into
Conversation
Signed-off-by: Ellis Sarza-Nguyen <sarzanguyen@google.com>
xorptr
approved these changes
Sep 5, 2026
| "HOTH_JTAG_OPERATION expected exactly %zu response bytes, got %zu\n", | ||
| sizeof(response), response_length); | ||
| return LIBHOTH_ERR_CONSTRUCT(HOTH_CTX_CMD_EXEC, HOTH_HOST_SPACE_LIBHOTH, | ||
| LIBHOTH_ERR_FAIL); |
Collaborator
There was a problem hiding this comment.
nit: Would it be a good idea to create a different error code for this condition? It can be done in a separate PR if you prefer to do so
| EXPECT_NE(libhoth_jtag_read_idcode(&hoth_dev_, interface_id, clk_idiv, | ||
| &received_idcode), | ||
| -1); | ||
| HOTH_SUCCESS); |
Collaborator
There was a problem hiding this comment.
nit: For the failure cases, do you think checking that a particular error code is returned for the particular scenario in the test would be useful? Or would it be too cumbersome to manage the tests if error codes are tied to particular error scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.