Skip to content

Fix substitution names in cloudbuild-monitor-zfa - #3212

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:fixZfa
Aug 17, 2026
Merged

Fix substitution names in cloudbuild-monitor-zfa#3212
gbrodman merged 1 commit into
google:masterfrom
gbrodman:fixZfa

Conversation

@gbrodman

@gbrodman gbrodman commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

We shouldn't have stripped the leading underscore in 84811d5. GCB requires user-defined substitutions to begin with an underscore.


This change is Reviewable

We shouldn't have stripped the leading underscore in 84811d5. GCB
requires user-defined substitutions to begin with an underscore.
@gbrodman
gbrodman requested a review from jicelhay August 17, 2026 17:41
@gbrodman
gbrodman enabled auto-merge August 17, 2026 17:46

@jicelhay jicelhay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jicelhay reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@gbrodman
gbrodman added this pull request to the merge queue Aug 17, 2026
Merged via the queue into google:master with commit 3dacd6c Aug 17, 2026
16 checks passed
@gbrodman
gbrodman deleted the fixZfa branch August 17, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants