Skip to content
This repository was archived by the owner on Dec 12, 2021. It is now read-only.
This repository was archived by the owner on Dec 12, 2021. It is now read-only.

Port bug fix for clobbered assets #15

Description

@fotinakis

Hello! We fixed a high-priority asset discovery bug in ember-percy and noticed that the gatherBuildResources method was also duplicated into this project with the same bug present.

The bug is present here:

function gatherBuildResources(percyClient, buildDirs, rootDirs) {

You should upgrade percy-client to 2.10.0, and then remove gatherBuildResources entirely and use the new method present on PercyClient objects: percyClient.gatherBuildResources.

See here for a reference bugfix from ember-percy: percy/percy-ember#70

Key to note: the method now returns an array, instead of a hash. If you need the hash you'll want to construct it in the same way as in the above reference.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions