perf(storage): add write_object upload strategies benchmarking suite - #6611
Open
xlai20 wants to merge 12 commits into
Open
perf(storage): add write_object upload strategies benchmarking suite#6611xlai20 wants to merge 12 commits into
xlai20 wants to merge 12 commits into
Conversation
…appendable_object
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new benchmark suite, storage-benchmark-write-object, to compare GCS write_object upload strategies and checksum modes. Feedback on the implementation highlights two style guide violations in source.rs: the use of blocking std::fs::create_dir_all within an asynchronous function, and the absence of required // SAFETY: comments on unsafe blocks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 306 306
Lines 93503 93503
=======================================
+ Hits 90263 90267 +4
+ Misses 3240 3236 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an independent benchmarking suite crate
storage-benchmark-write-objectundersrc/storage/benchmarks/write_objectto evaluate and compare different upload strategies and checksum validation mechanisms forwrite_object.This benchmarking suite provides empirical performance and throughput data across various payload sizes to inform the decision on the default
write_objectbehavior for seekable sources (e.g., local files).Scenarios Evaluated
Option_A_Unbuffered_Baseline):.send_unbuffered()Option_B_Unbuffered_2Pass):.precompute_checksums().await?.send_unbuffered()x-goog-hashserver-side validation header.Option_C_Buffered_Chunked):.send_buffered()Benchmark Features
libc::posix_fadvise(DONTNEED)before every iteration to ensure realistic, cold disk reads.GOOGLE_CLOUD_RUST_BENCHMARKS_STATS_OUTPUT_PATH.run_all.shdriver script to run all 5 tiers sequentially.Testing
cargo clippy --all-targets -- -D warnings, andcargo fmt.