Skip to content

impl(bigquery): allow retry/backoff policy override and use default policies - #6639

Draft
alvarowolfx wants to merge 2 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-add-policy-override-method
Draft

impl(bigquery): allow retry/backoff policy override and use default policies#6639
alvarowolfx wants to merge 2 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-add-policy-override-method

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #6218

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces with_retry_policy and with_backoff_policy builder methods to the BigQuery ClientBuilder, enabling custom retry and backoff configurations. It also updates the client to fall back on default policies when none are specified, cleans up obsolete #[allow(dead_code)] attributes, and adds unit tests. The feedback recommends removing an unused std::time::Duration import from the new doctest to avoid potential compilation warnings.

Comment thread src/bigquery/src/query/client_builder.rs
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (d6577c1) to head (99de16b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6639      +/-   ##
==========================================
+ Coverage   96.55%   96.57%   +0.01%     
==========================================
  Files         306      306              
  Lines       94212    94236      +24     
==========================================
+ Hits        90969    91005      +36     
+ Misses       3243     3231      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant