feat(gax): allow Google API client header to be overrided - #6665
Draft
alvarowolfx wants to merge 6 commits into
Draft
feat(gax): allow Google API client header to be overrided#6665alvarowolfx wants to merge 6 commits into
alvarowolfx wants to merge 6 commits into
Conversation
Contributor
Author
|
need to be done in sync with googleapis/librarian#7514 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the resolution and handling of the x-goog-api-client header across multiple generated transport modules. It introduces helper functions to resolve these headers for both gRPC and REST requests, improves code cleanliness by removing redundant #[allow(unused_imports)] attributes, and updates the ReqwestClient to support these changes. I have no feedback to provide.
coryan
reviewed
Sep 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6665 +/- ##
==========================================
- Coverage 96.67% 96.67% -0.01%
==========================================
Files 308 308
Lines 97938 97989 +51
==========================================
+ Hits 94683 94732 +49
- Misses 3255 3257 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow veneers to change header from GAPIC to veneer (gccl).
Towards #2138