cleanup(ci): refactor compute-full script - #6668
Open
suzmue wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the GCB script .gcb/scripts/compute-full.sh to split the cargo test execution into separate --lib and --doc runs, while removing the cargo clippy step. The reviewer noted that this split omits running integration tests and suggested adding a step to run them using --tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6668 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 308 308
Lines 97986 97986
=======================================
+ Hits 94725 94727 +2
+ Misses 3261 3259 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the cargo clippy from the compute-full script since it is already covered by lint.sh, hopefully reducing the build time of this build.
This also splits up tests into --lib and --doc. I don't expect this to help with the OOM issue at all, but it at least will make it very clear which step is causing the problem.