Phase 3: entities → ProblemSpec projection (closes #340) - #346
Draft
aarontrowbridge wants to merge 1 commit into
Draft
Phase 3: entities → ProblemSpec projection (closes #340)#346aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
) Deterministic Formulation+CompositeSystem → ProblemSpec per master spec mapping table (parameterization→pulse.kind+template, min_time→ goal_treatment both+free_dt+time objective, ensemble→sampling wrapper, leakage→options, custom→not spec-expressible fallback with reason, T/N/max_iter/integrator flow-through). - packages/schema/src/project.ts: new pure projection, validated via ajv - packages/schema/src/index.ts: export projection, table-sniff kindForFilename for legacy card vs spec (problem.toml collision) - packages/schema/julia/validate.jl: parity sniff - packages/extension/opencode-plugin/problems.ts: rename workspace card problem.toml→card.toml (card.json), legacy fallback + migration - packages/extension/opencode-plugin/amicode_tools.ts: amicode_formulate v2 projects → problem.toml/json ajv-validated; amicode_solve v2 reads problem.toml, applies T/N/max_iter/integrator overrides, emits solvespec.json with problem_spec path (still never launches) - vitest goldens in project.test.ts + card vs spec disambiguation Roadmap: plan-20260812-142100-problemspecs-issimo-roadmap W2.1 Spec: spec-20260717-020639-typed-problem-specs-piccolo-amicode Closes #340
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340
Roadmap:
plan-20260812-142100-problemspecs-issimo-roadmapW2.1Master spec:
spec-20260717-020639-typed-problem-specs-piccolo-amicode(entities ↔ ProblemSpec mapping table)What exists: solvespec v4 already routes
problem_spec→Piccolo.Specs.solve_spec(PROBLEM_SPEC_RUNNER). What's missing is the authoring side: deterministic TS projection.Changes:
packages/schema/src/project.ts— deterministicFormulationEntity+CompositeSystem→ProblemSpecper master spec table: parameterization→pulse.kind+template, min_time→goal_treatment both+free_dt+time objective, ensemble→sampling wrapper, leakage→options, custom→not spec-expressible fallback with reason, T/N/max_iter/integrator passthrough. Validated via ajv (problemspecschema) before write.amicode_formulatev2: projects →~/.amico/problems/<slug>/problem.toml(+ JSON sidecar) ajv-validated; entity TOMLs still written; fallback reason surfaced when not spec-expressible (script-tier).amicode_solvev2: readsproblem.toml/json, appliesT/N/max_iter/integratoroverrides, re-validates, rewrites spec, emitssolvespec.jsonwithproblem_specpath (still never launches — bash workflow owns launch).problem.toml→card.toml(andcard.json) with legacy fallback + migration, freeing the basename for the ProblemSpec; teachkindForFilename(TS + Julia) to table-sniff legacy cards soamico-validateno longer misfires.Verification:
pnpm --filter @amicode/schema test168 passed;pnpm --filter amicode test932 passed;@amicode/amico-run1 pre-existing flakyagent_spawnfailure (main also fails, unrelated). Do not merge.