Skip to content

feat: Data & Storage section in General Settings (amicode#378) - #200

Closed
jeonghun-jj-lee wants to merge 0 commit into
local/amicodefrom
jj/378-data-storage-settings
Closed

feat: Data & Storage section in General Settings (amicode#378)#200
jeonghun-jj-lee wants to merge 0 commit into
local/amicodefrom
jj/378-data-storage-settings

Conversation

@jeonghun-jj-lee

Copy link
Copy Markdown
Contributor

App-side implementation for the Data & Storage settings section (harmoniqs/amicode#378):

  • en.ts: i18n keys for the section, two path fields, and inline error strings
  • settings.tsx: Settings.storage interface (databasePath, configDir) + defaults + accessors
  • data-storage-controller.ts (new): reactive controller that queries defaults on mount and dispatches data-storage-update on blur
  • data-storage.tsx (new): section component — two TextInputV2 fields with resolved-default placeholders and inline validation
  • general.tsx: renders <DataStorageSection /> between Display and Advanced
  • settings-v2.css: .settings-v2-field-error inline style

Extension-side PR: harmoniqs/amicode#380

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jeonghun-jj-lee, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02553a43-3325-4de2-8a9f-b9aa258ce138

📥 Commits

Reviewing files that changed from the base of the PR and between ac63b7f and f342cea.

📒 Files selected for processing (5)
  • packages/app/src/components/settings-v2/data-storage-controller.ts
  • packages/app/src/components/settings-v2/data-storage.tsx
  • packages/app/src/components/settings-v2/general.tsx
  • packages/app/src/context/settings.tsx
  • packages/app/src/i18n/en.ts

Comment @coderabbitai help to get the list of available commands.

@jeonghun-jj-lee
jeonghun-jj-lee force-pushed the jj/378-data-storage-settings branch from bbde875 to f342cea Compare August 14, 2026 15:15
@jeonghun-jj-lee
jeonghun-jj-lee force-pushed the jj/378-data-storage-settings branch from f342cea to ac63b7f Compare August 14, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant