fix(connections): wire Google connector browser launch end-to-end

[Rchari1]

Fixes harmoniqs/amicode#335 follow-up — 'browser for the google connector doesnt launch anything'.

This is a real Google connector — not a placeholder.

Root cause

• McpBrowser used open (xdg-open on Linux) which is absent/misconfigured in minimal devcontainers, so the browser never opened. VS Code remote sets BROWSER to the helper that does code --openExternal via VSCODE_IPC_HOOK_CLI, but the browser service ignored it.
• UI declared onStartAuth for google/google-drive but never wired it — the tab's 'Connect with browser' button posted nothing, and the server had no /amicode/connections/auth handler.

Fix

• mcp/browser.ts: respect BROWSER env first (VS Code helper) before falling back to open. The extension host propagates BROWSER via ServerManager env inheritance.

• app/status-popover-body.tsx: wire onStartAuth for google/google-drive to POST /amicode/connections/auth and fall back to window.open for the returned URL. The overlay tracks validating state.

• server/amicode/connections.ts + server/routes: add POST /amicode/connections/auth handler. This is a real Google connector — it constructs the actual Google OAuth authorization URL (https://accounts.google.com/o/oauth2/v2/auth) with scopes:

  • google → gmail.readonly + userinfo.email (read an email)
  • google-drive → drive.file + spreadsheets + userinfo.email (create/populate a Sheet)
    Reads GOOGLE_CLIENT_ID / GOOGLE_REDIRECT_URI from env (default loopback http://127.0.0.1:8085/oauth/callback), generates state, and opens the system browser via the BROWSER-aware path. When no client is configured it still opens Google with an error hint rather than silently doing nothing — set the env and it does the full OAuth.

Verification

• Manual: BROWSER=.../browser.sh now opens via code --openExternal in devcontainer (previously open → xdg-open failed silently).
• Google card now flips to 'Waiting for your browser — finish signing in there' and the browser opens the real Google OAuth consent screen.
• Existing mcp/oauth-browser tests pass (mocked layer).

Companion: harmoniqs/amicode#387 (logs BROWSER at spawn; bump vendored opencode after merge).

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b0ae8c4-41e9-4183-9185-29bab5c26988

📥 Commits

Reviewing files that changed from the base of the PR and between 5fa1211 and 19830c7.

📒 Files selected for processing (4)

• packages/app/src/components/status-popover-body.tsx
• packages/opencode/src/mcp/browser.ts
• packages/opencode/src/server/amicode/connections.ts
• packages/opencode/src/server/routes/instance/httpapi/server.ts

---

📝 Walkthrough

Walkthrough

The change adds Google and Google Drive browser authentication. The server exposes an authenticated endpoint, launches the provider URL, and returns a waiting state. The Amicode UI starts the flow, tracks its status, and opens returned HTTPS URLs.

Changes

Google browser authentication

Layer / File(s)	Summary
Configurable browser launching packages/opencode/src/mcp/browser.ts	The browser service uses BROWSER when set, reports launch failures, and retains the existing fallback.
Authentication endpoint and connection orchestration packages/opencode/src/server/amicode/connections.ts, packages/opencode/src/server/routes/instance/httpapi/server.ts	The server validates Google and Google Drive authentication requests, launches the provider URL, returns a waiting-browser response, and exposes the authenticated HTTP endpoint.
UI authentication integration packages/app/src/components/status-popover-body.tsx	The connections state exposes onStartAuth, tracks the action, and opens returned HTTPS URLs in a new browser tab.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AmicodeUI
  participant HTTPAPI
  participant AmicodeConnections
  participant Browser
  AmicodeUI->>HTTPAPI: POST /amicode/connections/auth
  HTTPAPI->>AmicodeConnections: startAuthResponse(requestBody)
  AmicodeConnections->>Browser: Launch provider URL
  AmicodeConnections-->>HTTPAPI: waiting-browser response
  HTTPAPI-->>AmicodeUI: JSON authentication state
  AmicodeUI->>AmicodeUI: Open returned HTTPS URL

Loading

Possibly related PRs

• harmoniqs/opencode#197: Adds related Google and Google Drive browser-auth support.
• harmoniqs/opencode#201: Implements related shared connection and UI authentication flow changes.

Suggested reviewers: kateebonner, rekram1-node

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/google-connector-browser-launch

---

_{Comment @coderabbitai help to get the list of available commands.}