swift sdk: the README's install line names the SDK's real first version - #140
Merged
Merged
Conversation
`from: "0.1.0"` is SwiftPM's range 0.1.0 ..< 1.0.0, and every tag in that range on hausfold/scruff-swift is the pre-rename package whose only product is `Holt`. A consumer copying the line resolved to 0.5.0 and got no `Scruff` product. 1.0.0 is the first tag that ships `Scruff`, and the number the manual (content/docs/scruff/sdks.mdx) already gives. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sdk/swift/README.md:24now readsfrom: "1.0.0"instead offrom: "0.1.0".Why
from: "0.1.0"is SwiftPM's range0.1.0 ..< 1.0.0. Every tag in that range onhausfold/scruff-swift(0.1.0 to 0.5.0) is the pre-rename package whose only product isHolt, so a consumer copying the line resolved to 0.5.0 and got noScruffproduct. 1.0.0 is the first tag with aScruffproduct, and the number the manual (content/docs/scruff/sdks.mdx) already gives.Verify
gh api repos/hausfold/scruff-swift/tags --paginatelists 0.1.0 through 1.5.1.Package.swiftat tag 0.5.0 declares.library(name: "Holt"); at 1.0.0 it declares.library(name: "Scruff").0.1.0insdk/swiftbesides the test fixture's fake CLI version string, which is unrelated.Watch out
sdk/swiftis the source andhausfold/scruff-swiftthe generated mirror, so the change lands here and reaches the mirror on the nextv*tag. A README-only change touches no SDK surface, so nothing to release for it.🤖 Generated with Claude Code