Conversation
… table status.admission.podSetAssignments[].topologyAssignment was typed as unknown and never rendered, even though the plugin already fetches it. Add proper TopologyAssignment/TopologyDomainAssignment interfaces, a formatter, and a Topology Assignment column on the Workload detail page's Admission table. Fixes headlamp-k8s#1297 Signed-off-by: Aarush <aarushsingh1305@gmail.com>
xonas1101
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
September 15, 2026 09:39
Author
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The topology assignment model does not match v1beta2, leaving the new column empty for real v1beta2 assignments.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR types Kueue topology assignments and displays them in the Workload Admission table.
Changes:
- Adds topology assignment interfaces.
- Adds readable topology formatting and tests.
- Adds the Topology Assignment table column.
Review finding: The model uses the v1beta1 domains shape instead of v1beta2 slices, so real v1beta2 assignments will render as empty. The types and formatter should support the correct version(s). (Moderate, 2 votes.)
File summaries
| File | Summary |
|---|---|
kueue/src/resources/workloadFormatters.ts |
Formats topology assignment details. |
kueue/src/resources/workloadFormatters.test.ts |
Tests topology formatting. |
kueue/src/resources/workload.ts |
Defines topology assignment types. |
kueue/src/components/workloads/Detail.tsx |
Displays topology assignments in the Admission table. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Workload fetches v1beta2 first, and v1beta2's TopologyAssignment is a list of slices (domainCount, valuesPerLevel, podCounts) rather than a flat list of domains. The previous model matched v1beta1 and would have rendered empty on real v1beta2 clusters. Expand slices into per-domain values and counts for display. Signed-off-by: Aarush <aarushsingh1305@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1297
status.admission.podSetAssignments[].topologyAssignment was typed as
unknowninsrc/resources/workload.tsand never rendered, even though the plugin already fetches it on the Workload detail page.Changes:
TopologyAssignmentandTopologyDomainAssignmentinterfaces matching Kueue's v1beta2 API, replacing theunknowntyperenderTopologyAssignmentformatter that renders levels and domains as readable text instead of a raw objectRan locally: build, tsc, lint, format --check, and test all pass.