C++14 support: remove usage of structure bindings from generated code - #1815
Merged
pwrobeldev merged 2 commits intoAug 31, 2026
Merged
Conversation
Hsilgos
previously approved these changes
Aug 28, 2026
The generated JNI layer used C++17 feature called structure binding. To restore compilation with C++14 this commit introduces usage of std::get(). Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
Signed-off-by: Patryk Wrobel <183546751+pwrobeldev@users.noreply.github.com>
pwrobeldev
force-pushed
the
pwrobeldev/return-support-of-cpp14-structure-bindings
branch
from
August 31, 2026 13:40
f67c976 to
c5c7008
Compare
Hsilgos
approved these changes
Aug 31, 2026
pwrobeldev
deleted the
pwrobeldev/return-support-of-cpp14-structure-bindings
branch
August 31, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
---------- Problem contex ----------
The generated C++ code and bindings must be compilable with C++14.
The code related to JNI layer had been using structure bindings that is
a feature introduced in C++17.
---------- Implemented fix ----------
Replaced the structure bindings with call to
std::get()to achieve similarbehavior. This ensures that the code is compatible with C++14.