Lync cleanup and a zone-name cache - #7
Open
theharshl wants to merge 7 commits into
Open
Conversation
…and Lync clients, data models, constants, and tests.
- Update MCA bass/treble/balance range to -12..12 - Enforce step size of 4 for bass/treble and 6 for balance - Remove scaling logic from client and HA integration - Add unit tests for MCA audio control logic and rounding - Bump version to 0.0.26
…ance declaration SET_ECHO_COMMAND_CODE and QUERY_ID_CODE are already defined in constants.py — drop the defensive hasattr ternaries in lync_client.py. Also add the missing @AbstractMethod declaration for async_set_balance in base_client.py alongside async_set_bass and async_set_treble.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Populate _zone_names on every ZONE_NAME_RECEIVE_COMMAND regardless of whether zone_data exists yet. Expose get_zone_name(zone) -> str | None mirroring get_source_name(). Also initialize _zone_names in async_connect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… cache tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kingfetty's Lync work reaches for a couple of command codes through
hasattrwith hardcoded fallbacks, because the constants didn't exist yet. This promotes them to real constants and drops the guards, adds an abstractasync_set_balancedeclaration so both clients agree on the interface, and removes the dangling.lync_clonesubmodule reference that breaks a clean checkout.It also adds
get_zone_name()backed by its own_zone_namescache, kept separate from the source-name cache. The integration needs it to show controller-assigned zone names.Depends on PR #5 and PR #4 — this branch is based on them, so their commits appear in the diff until they merge.
Tests: 157 passing.
Part of the fork-upstreaming stack — see hikirsch/htd-home-assistant#34. Please merge with a plain merge commit so the rest of the stack stays intact.