fix: harden real Python tool execution and path/timeout handling - #12
Merged
Merged
Conversation
- Add deterministic timeout support to RealPythonTool subprocess execution - Handle single path strings and multiple paths cleanly in run_lint operation - Return structured ToolResult on TimeoutExpired - Add comprehensive unit tests in tests/tools/test_real_python_tool.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RealPythonTool lacked deterministic subprocess timeout handling and did not normalize single/multiple path inputs during lint operations.
Implementation
timeoutparameter with default 60.0s to_runandRealPythonTool.execute.pathsparameter inrun_lintto support both string and list formats.subprocess.TimeoutExpiredgracefully returning a structured failureToolResult.tests/tools/test_real_python_tool.py.Verification
pytest -m 'not azure_integration'.flake8andmypypassed cleanly across all 133 source files.terraform fmt -check -recursivepassed.