Ilya/fireworks cookbook resume fixes - #672
Merged
shfunc merged 2 commits intoSep 18, 2026
Merged
Conversation
solvemproblr
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Resume changes training client setup and when tokenizer/renderer load; wrong flags on non-default checkpoints could fail or mis-tokenize before training starts.
Overview
Resume and model resolution for the Fireworks RL cookbook:
--resume-fromnow looks up the checkpoint’s base model via the Fireworks REST API and overrides CLI--base-modelbefore tokenizer/renderer setup. Non-default models must pass both--tokenizer-modeland--renderer(defaults apply only for Qwen 3.8 27B). The startup banner andconfig.jsonrecord the resolved model, tokenizer, and renderer.Checkpoint visibility: each
state-NNNNandfinal-statesave printsTraining checkpoint: <full path>immediately so paths are available even if a later step fails.Tests and docs: new unit tests cover resume model override, missing rendering args on alternate bases, and checkpoint logging before failures; README and v6 cookbook docs describe the updated resume flow and CLI help.
Reviewed by Cursor Bugbot for commit 315cce4. Bugbot is set up for automated code reviews on this repo. Configure here.