fix: remove five files nothing references - #66
Merged
Conversation
Found by a hygiene sweep of the whole tree, not just a diff. Each was checked
for references across the repo before removal, and the role-file-reference gate
still resolves all 54 static references afterwards.
roles/soe/files/default-background.svg
roles/developer/files/branding/background.svg
Byte-identical copies (md5 51893ea6) of the wallpaper that now lives in
roles/soe-gui/files/, beside the task that copies it. Nothing could reach
either: Ansible resolves a `src:` against the current role's files/ and
the playbook directory, never a sibling role. ~494KB each.
roles/developer/files/branding/avatar.svg
No reference anywhere. avatar_file has defaulted to user-avatar.png since
the branding feature's first commit, so this was never wired up.
roles/developer/files/update/hyperi-update.png
update_command.yml deploys only the .svg (Linux icon) and AppIcon.icns
(macOS); the .desktop file's Icon= resolves via the installed .svg.
tools/add-dev-user.sh
Byte-identical (md5 dec58a0e) to roles/developer/files/add-dev-user, the
copy Ansible actually installs to /usr/local/sbin. Referenced by nothing
-- not tools/README.md, not any script or doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five files nothing references, found by a hygiene sweep of the whole tree rather than a diff. Each was checked for references across the repo before removal, and the role-file-reference gate still resolves all 54 static references afterwards.
roles/soe/files/default-background.svg51893ea6) of the wallpaperroles/developer/files/branding/background.svgroles/developer/files/branding/avatar.svgroles/developer/files/update/hyperi-update.png.svgand.icnsare deployedtools/add-dev-user.shdec58a0e) to the copy Ansible installsThe two wallpaper duplicates are ~494KB each. Neither was reachable: Ansible resolves a
src:against the current role'sfiles/and the playbook directory, never a sibling role. The live copy sits inroles/soe-gui/files/, beside the task that copies it.avatar_filehas defaulted touser-avatar.pngsince the branding feature's first commit, sobranding/avatar.svgwas never wired up.update_command.ymldeploys the.svg(Linux icon) andAppIcon.icns(macOS), and the.desktopfile'sIcon=resolves via the installed.svg, so the.pnghas no path to a machine.tools/add-dev-user.shduplicatesroles/developer/files/add-dev-user, which is the copy that actually reaches/usr/local/sbin. Nothing referenced thetools/one -- nottools/README.md, not any script or doc.tools/ci/run-tests.shgreen.