fix: install git-scrub with the contributor toolchain - #70
Open
catinspace-au wants to merge 1 commit into
Open
Conversation
We use git-scrub to rewrite AI residue and leaked secrets out of git history, but nothing in the installer put it on a box -- everyone was fetching it by hand. It goes in contributor rather than soe because it is what clears a gitleaks failure, and gitleaks scans full history: a secret removed from HEAD still fails the gate. soe inherits it through meta/dependencies. Snipeable on its own with --tags git-scrub. GitHub release tarball on every platform. That is the only rung going -- it is not on crates.io, downloads.hyperi.io serves no git-scrub path, and the release ships a git-scrub.rb that is not in our tap yet, so macOS takes the darwin asset until someone taps it. The tarball is kept rather than deleted, and that is what makes the role idempotent: get_url re-reports ok for an unchanged asset so the extract and install stay skipped on a converged box. We cannot ask the binary its version instead -- v1.0.2 reports itself as "git-scrub 1.0.1".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use git-scrub to rewrite AI residue and leaked secrets out of git history, but nothing in the installer ever put it on a box, so everyone was fetching it by hand.
It goes in
contributor, notsoe, because it is what clears a gitleaks failure and gitleaks scans FULL history: a secret removed from HEAD still fails the gate.soeinherits it through meta/dependencies. Snipeable on its own with--tags git-scrub.GitHub release tarball on every platform. That is the only rung going:
downloads.hyperi.ioserves no git-scrub path (404)git-scrub.rbthat is not in our tap yet, so macOS takes the darwin asset until someone taps itThe tarball is KEPT rather than deleted, and that is what makes the role idempotent -
get_urlre-reports ok for an unchanged asset, so the extract and install stay skipped on a converged box. We cannot ask the binary its version instead, because v1.0.2 reports itself as "git-scrub 1.0.1".Done when git-scrub installs on a fresh box, a second run is all green, and the docs match.
Verified
ansible-linton the new file: 0 failures, production profile--syntax-check: ok--checkrun of the tag: failed=0, rescued=0okwith extract/install/cleanup allskippinggit-scrub --versionruns from/usr/local/bintools/ci/run-tests.sh: all available checks passedNot verified
Known and left alone
register: verify_git_scrubtripsvar-naming[no-role-prefix]. Its three neighbours in that file trip the identical rule, so I kept the local convention rather than being the odd one out. Fixing all four is a separate tidy-up.hyperi-ci checkfails with "Could not detect project language" on this branch AND on clean main, so it is pre-existing, not this change.