refactor: dedupe scoring tests and reason mapping - #38
Merged
Merged
Conversation
Replace copy-pasted cases with it.each tables and shared helpers in score.test.js (classify, display-changes, acceptance, rejection) and abstract-provider-cascade.test.js (error trio, earth payload, level-call assertions). Extract e2e scenario helpers (seed, open page, fill/accept, call asserts, teardown) in provider-contract.spec.js. Collapse the suppression-reason if-ladder in lib/score.js into an insertion-ordered lookup table with identical output ordering. No behavior changes; addresses Sonar new-code duplication.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Removes jq formatting churn left by the release bump workflow so biome ci passes. Version unchanged (0.4.10).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SonarQube new-code duplication (7.4% vs 3% gate).
No behavior changes. Net -58 lines.