Skip to content

IBX-12237: Passed Search extraClasses to InputTextInput wrapper instead of the input - #2002

Open
tischsoic wants to merge 2 commits into
6.0from
IBX-12237-image-library-search
Open

IBX-12237: Passed Search extraClasses to InputTextInput wrapper instead of the input#2002
tischsoic wants to merge 2 commits into
6.0from
IBX-12237-image-library-search

Conversation

@tischsoic

@tischsoic tischsoic commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-12237

Related PRs:

⚠️ Merge order: the design-system PR should merge first.

Description:

The shared Search component (common/input/filter.search.js) routed its extraClasses prop through extraAria.className, which lands on the raw <input> and — due to spread order in the DS BaseInput — replaced the ids-input* classes entirely. With the default extraClasses = '' (the Image library case) the input rendered as <input class="">, i.e. completely unstyled.

extraClasses is now passed to InputTextInput's className prop (the .ids-input-text wrapper), matching the established pattern in top.menu.search.input.js.

Consumers checked: image-picker passes no extraClasses; segmentation passes c-segments__sidebar-filter, which has no SCSS/JS references anywhere in that package, so moving the class from the input to the wrapper changes nothing visually.

For QA:

  1. Create/edit content with an image assets field → Select from library → the search input in the Image library header must be styled like other DS inputs (border, 40px height, magnifier button inside).
  2. Regression: UDW top-menu search (browse tab), dropdown/popup-menu filter inputs — unchanged.
  3. Page Builder → block targeting (segmentation) sidebar segment filter — unchanged.

Documentation:

@katarzynazawada
katarzynazawada force-pushed the IBX-12237-image-library-search branch from d0648bc to 0934ab6 Compare August 18, 2026 07:24
tischsoic and others added 2 commits August 18, 2026 10:05
…ad of the input

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
className, autoFocus and onKeyUp are not ARIA attributes and did not belong in extraAria. popup.menu.search.js no longer re-declares the ids-input classes by hand, since BaseInput derives them from the size prop.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tischsoic
tischsoic force-pushed the IBX-12237-image-library-search branch from 0934ab6 to 8852844 Compare August 18, 2026 08:05
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants