IBX-11181: Added trusted_proxies ACL to Varnish setup - #65
Draft
vidarl wants to merge 2 commits into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Supports the reverse proxy header filtering added in ibexa/http-cache#87.
varnish5/6/7.vclnow strip client suppliedX-Forwarded-*andForwardedheaders unless the peeris listed in a new
trusted_proxiesACL. That ACL has to exist inparameters.vcl, since Varnishresolves ACLs at VCL load time and otherwise refuses to load the configuration.
parameters.vclgains thetrusted_proxiesACL, holding localhost only. The Docker network isdeliberately left out: nothing runs in front of Varnish in this setup, so every incoming request
is treated as coming straight from a client.
entrypoint.shgains--trusted-proxy-add, mirroring the existing--acl-addand--debug-acl-addflags.varnish-trusted-proxy.ymlis a new overlay that adds the app container to that ACL, for theBehat suite. It applies on top of any of
varnish.yml,varnish7.ymlorvarnish9.yml, since they all define the samevarnishservice.