Conversation
Contributor
|
All contributors have signed the @imqueue Contribution Terms. ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Mikhus
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes a lost or silently un-retried job visible.
push()is fire-and-forget, so a job which never reached Redis used to leave no trace on either side.[JobQueue] push error:— the existing marker text, unchanged — now also covers a write rejected afterpush()returned, which the underlying queue reports through an error handler only. It is written aterrorlevel and carries the queue name, the requested delay and ttl and a failure code. A failure the Redis client delivers twice, through both its command callback and its returned promise, still writes one line.The handler-failure line now states what happens next —
retry in <ms>orno retry— together with the message id, so a stalled retry loop can be told apart from a handler which gave up. Two more cases get their own line: a retry suppressed because the job's ttl had expired, and a re-schedule whose write to Redis failed, which means the retry the previous line promised is not coming.A failure reason is never taken from the error as it is: only an allow-listed code is printed — a framework
IMQ_…code, a systemE…code, a small integer, a known Redis reply code or a known Redis-client failure message mapped to a code of our own; everything else becomesunknown. The job body is never logged, and a logger which throws cannot influence the queue — including that it no longer cancels a re-schedule, which is the one deliberate behavioural difference.No control flow, return value, retry decision or timer was changed otherwise.
Type of change
Checklist
npm test).Contribution terms (required)
I grant the project owner the right to license my contribution
commercially, royalty-free, my contribution stays available under
GPL-3.0, I keep my copyright, and I understand I will receive no fee for
it. If I did not agree, I would not be submitting this contribution.