Fix directory Dockerfile - #744
Open
adamdickmeiss wants to merge 7 commits into
Open
Conversation
And ensure it's checked when performing 'git push'.
adamdickmeiss
requested review from
JanisSaldabols and
jakub-id
as code owners
September 1, 2026 12:54
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Directory container build and adds pre-push validation.
Changes:
- Includes the local
testutilmodule through a Go workspace. - Adds the Directory Docker build to the pre-push hook.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pre-push |
Builds the Directory image before pushing. |
directory/Dockerfile |
Makes local module dependencies available during generation and compilation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jakub-id
previously approved these changes
Sep 1, 2026
jakub-id
reviewed
Sep 1, 2026
| WORKDIR /app/directory | ||
| RUN go work init \ | ||
| ./directory \ | ||
| ./testutil |
Contributor
There was a problem hiding this comment.
why do we need testutil in the container?
Contributor
Author
There was a problem hiding this comment.
We moved the pg container util there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.