Fix new ruff errors

pyproject.toml

@@ -90,15 +90,16 @@ extend-select = [
     "W",    # pycodestyle
 ]
 extend-ignore = [
-    "C90",      # McCabe complexity
+    "complex-structure",
+    "f-string",
+    "invalid-argument-name",
+    "invalid-function-name",
     "missing-whitespace-around-arithmetic-operator",
     "module-import-not-at-top-of-file",
-    "invalid-function-name",
-    "invalid-argument-name",
-    "non-lowercase-variable-in-function",
     "non-empty-init-module",
+    "non-lowercase-variable-in-function",
     "printf-string-formatting",
-    "f-string",
+    "pytest-parameter-with-default-argument",
 ]
 exclude = [
     "experiments/*.py",

pytential/symbolic/primitives.py

@@ -2048,7 +2048,7 @@ def __post_init__(self) -> None:
                  "Passing a different type is deprecated and will stop being "
                  "supported in 2027.", DeprecationWarning, stacklevel=2)
 
-            kernel_arguments = self.kernel_arguments if self.kernel_arguments else {}
+            kernel_arguments = self.kernel_arguments or {}
             object.__setattr__(self, "kernel_arguments", constantdict(kernel_arguments))
 
         from pytools import single_valued
@@ -2058,8 +2058,10 @@ def __post_init__(self) -> None:
 
         kernel_arg_names: set[str] = set()
         for kernel in kernels:
-            for karg in (*kernel.get_args(), *kernel.get_source_args()):
-                kernel_arg_names.add(karg.loopy_arg.name)
+            kernel_arg_names.update(
+                karg.loopy_arg.name
+                for karg in (*kernel.get_args(), *kernel.get_source_args())
+            )
 
         provided_arg_names = set(self.kernel_arguments.keys())
         if missing_args := (kernel_arg_names - provided_arg_names):

test/test_layer_pot_identity.py

@@ -148,9 +148,8 @@ def check(self) -> None:
 
 @dataclass
 class StarfishGreenTest(StaticTestCase):
-    expr: IdentityExpr = field(default_factory=lambda: GreenExpr())
-    geometry: ied.IntegralEquationTestCase = field(
-        default_factory=lambda: ied.StarfishTestCase())
+    expr: IdentityExpr = field(default_factory=GreenExpr)
+    geometry: ied.IntegralEquationTestCase = field(default_factory=ied.StarfishTestCase)
 
     k: float = 0
     qbx_order: int = 5
@@ -165,9 +164,9 @@ class StarfishGreenTest(StaticTestCase):
 
 @dataclass
 class WobblyCircleGreenTest(StaticTestCase):
-    expr: IdentityExpr = field(default_factory=lambda: GreenExpr())
+    expr: IdentityExpr = field(default_factory=GreenExpr)
     geometry: ied.IntegralEquationTestCase = field(
-        default_factory=lambda: ied.WobbleCircleTestCase())
+        default_factory=ied.WobbleCircleTestCase)
 
     k: float = 0
     qbx_order: int = 3
@@ -180,9 +179,8 @@ class WobblyCircleGreenTest(StaticTestCase):
 
 @dataclass
 class SphereGreenTest(StaticTestCase):
-    expr: IdentityExpr = field(default_factory=lambda: GreenExpr())
-    geometry: ied.IntegralEquationTestCase = field(
-        default_factory=lambda: ied.SphereTestCase())
+    expr: IdentityExpr = field(default_factory=GreenExpr)
+    geometry: ied.IntegralEquationTestCase = field(default_factory=ied.SphereTestCase)
 
     k: float = 0
     qbx_order: int = 3

test/test_symbolic.py

@@ -308,7 +308,7 @@ def discr_and_nodes(stage):
     if name in ("default", "default_explicit", "stage2", "quad"):
         error = la.norm(sigma_target_interp - sigma_target) / la.norm(sigma_target)
         assert error < 1.0e-10
-    elif name in ("stage2_center",):
+    elif name == "stage2_center":
         assert len(sigma_target_interp) == 2 * len(sigma_target)
     else:
         raise ValueError(f"unknown test case name: {name}")