Rework sympy to pymbolic mappers - #305
Draft
alexfikl wants to merge 2 commits into
Draft
Conversation
alexfikl
marked this pull request as draft
September 4, 2026 18:26
Collaborator
Author
|
Hmm.. this needs a bit more work. It needs to make a distinction between |
alexfikl
force-pushed
the
refactor-sympy-mapper
branch
from
September 4, 2026 18:35
be27a05 to
463be35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mappers previously inherited from either the Sympy or SymEngine variants based on
USE_SYMENGINE. This meant that you couldn't use them at all for the other one, e.g. ifUSE_SYMENGINE=Truethere was no way to convertsympyexpressions.This implements both variants (with some code duplication) and adds
to_pymbolicandto_symbolichelper functions that do the actual dispatch based onUSE_SYMENGINE.