Adapt postQuery to allow setting of external query - #3940
Open
awildturtok wants to merge 2 commits into
Open
Conversation
awildturtok
force-pushed
the
feature/providable-query-id
branch
2 times, most recently
from
August 17, 2026 10:38
a2adf0b to
079490a
Compare
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
August 17, 2026 13:54
079490a to
813450b
Compare
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
August 17, 2026 15:57
813450b to
31f586a
Compare
thoniTUB
requested changes
Aug 20, 2026
| final QueryDescription query = new ConceptQuery(new CQOr(queries, Optional.of(false), DateAggregationAction.BLOCK)); | ||
|
|
||
| final ManagedExecution execution = postQuery(dataset, query, subject, true); | ||
| final ManagedExecution execution = postQuery(dataset, query, subject, true, Optional.empty(), true); |
Collaborator
There was a problem hiding this comment.
Die linter sollten es eigentlich immer ankreiden, wenn man Optional als Input verwendet.
Lieber die eigentliche Funktion overloaden.
| @POST | ||
| public Response postQuery(@Auth Subject subject, @QueryParam("all-providers") Optional<Boolean> allProviders, @NotNull @Valid QueryDescription query) { | ||
| public Response postQuery(@Auth Subject subject, @QueryParam("all-providers") Optional<Boolean> allProviders, @QueryParam("queryId") Optional<UUID> queryId, @NotNull @Valid QueryDescription query) { | ||
| return submitMaybeRun(queryId, subject, query, true, allProviders); |
Collaborator
There was a problem hiding this comment.
Kannst du da bitte separate Methoden daraus machen und dafür die darunterliegende Methode aufteilen und diese dann für die beiden Methoden unterschiedlich komponiert aufrufen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.