ci: improved credentials in tekton containers - #2707
Draft
kirrg001 wants to merge 2 commits into
Draft
Conversation
kirrg001
commented
Aug 10, 2026
| export $CRED=$(ibmcloud sm secret-value-get --name "$CRED" --service-name "$SM_SERVICE_NAME" --output json | jq -r '.resources[0].secret_data.payload') | ||
| done | ||
| fi | ||
| unset API_KEY |
Contributor
Author
There was a problem hiding this comment.
This is the most important thing.
aryamohanan
reviewed
Aug 10, 2026
aryamohanan
reviewed
Aug 10, 2026
aryamohanan
reviewed
Aug 10, 2026
aryamohanan
approved these changes
Aug 10, 2026
aryamohanan
left a comment
aryamohanan
left a comment
Contributor
There was a problem hiding this comment.
The idea looks cool. Let’s try it out.
| exit 0 | ||
| fi | ||
| fi | ||
| if [ "false" == "true" ]; then |
Contributor
There was a problem hiding this comment.
In the non-collector tests, including serverless, AWS Lambda, etc., the logic for cleaning up API_KEY is currently inside dead code that never executes:
if [ "false" == "true" ]; thenWe can simply unset API_KEY just after the offline cache fetch step.
Also, this logic is not required in these files and can be removed, right?
Contributor
There was a problem hiding this comment.
Hmm... since this is template-generated, we can maybe use the end of this block to unset API_KEY, so that it will be applied to all tasks irrespective of the SM fetch step 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-108160