[UR] Fix logger use-after-free during shutdown teardown - #23069
Open
pbalcer wants to merge 1 commit into
Open
Conversation
pbalcer
changed the title
pbalcer
force-pushed
the
use-after-free-sanitizer-logger
branch
from
September 1, 2026 10:22
d43bb8e to
bc57601
Compare
KFilipek
approved these changes
Sep 1, 2026
ldorau
approved these changes
Sep 1, 2026
SharedLayer::tearDown() logs while unloading the sanitizer library, but get_logger()'s singleton sink may already be freed. The isTearDowned latch that guards this was only set by ~StderrSink, so it stayed false for stdout/file sinks (used under SYCL_UR_TRACE), and the log dereferenced the freed sink. Set the latch from the get_logger() singleton's destructor so it fires for any sink type.
ldorau
approved these changes
Sep 1, 2026
Contributor
Author
|
@kswiecicki please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On shutdown, SharedLayer::tearDown() logs while unloading the sanitizer
library, but get_logger()'s singleton sink may already be freed. The
isTearDowned latch that guards this was only set by ~StderrSink, so it
stayed false for stdout/file sinks (used under SYCL_UR_TRACE), and the
log dereferenced the freed sink.
Set the latch from the get_logger() singleton's destructor so it fires
for any sink type.