[UR][L0] Call zeCommandListAppendHostFunction directly since L0 1.17 - #23070
Draft
ldorau wants to merge 1 commit into
Draft
[UR][L0] Call zeCommandListAppendHostFunction directly since L0 1.17#23070ldorau wants to merge 1 commit into
ldorau wants to merge 1 commit into
Conversation
Starting with Level Zero driver version 1.17, zeCommandListAppendHostFunction is part of the core API, so it can be called directly instead of being resolved via zeDriverGetExtensionFunctionAddress. For older drivers, keep resolving it dynamically as an extension. Update the ZeHostTaskExtension::zeCommandListAppendHostFunction function pointer type to match the real API signature (ze_host_function_callback_t, const void *pNext, ze_event_handle_t *phWaitEvents), and fix the call site in command_list_manager.cpp to cast pfnHostTask to ze_host_function_callback_t instead of void *, avoiding an invalid void* to function-pointer conversion. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
|
Please review @kswiecicki @KFilipek |
KFilipek
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Level Zero driver version 1.17,
zeCommandListAppendHostFunctionis part of the core API, so it can be called directly instead of being
resolved via
zeDriverGetExtensionFunctionAddress. For older drivers, keepresolving it dynamically as an extension.
Update the
ZeHostTaskExtension::zeCommandListAppendHostFunctionfunctionpointer type to match the real API signature (
ze_host_function_callback_t, const void *pNext, ze_event_handle_t *phWaitEvents), and fix the call sitein command_list_manager.cpp to cast
pfnHostTasktoze_host_function_callback_tinstead ofvoid *, avoiding an invalidvoid *to function-pointer conversion.Ref: Jira URT-1275