[SYCL][NFC] Don't use legacy group functions - #23071
Conversation
use new instead.
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates SYCL stream group-printing to avoid legacy group APIs by switching to newer group identifiers and recomputing derived ranges.
Changes:
- Replace
Group.get_id()withGroup.get_group_id() - Stop using
Group.get_global_range()by deriving global range fromgroup_rangeandmax_local_range - Reuse
group_rangevia a local variable to avoid duplicate calls
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Len += append(Buf + Len, "id: "); | ||
| Len += ArrayToStr(Buf + Len, Group.get_id()); | ||
| Len += ArrayToStr(Buf + Len, Group.get_group_id()); | ||
| Len += append(Buf + Len, ", global_range: "); |
There was a problem hiding this comment.
@dm-vodopyanov copilot is right. I'm wondering if we should get id of this line. It looks like in SYCL 2020 the group class doesn't know what global_range is and there is no API to get the number of all work items via group.
There was a problem hiding this comment.
Nope, he's not right, seems like work-groups always have the same number of work-items:
llvm/sycl/include/sycl/group.hpp
Lines 174 to 176 in 7113f3e
|
known failures |
use new instead.