Fix IMAGE1D and IMAGE1D_ARRAY image type deduction in addImage - #484
Open
bigmat18 wants to merge 1 commit into
Open
Fix IMAGE1D and IMAGE1D_ARRAY image type deduction in addImage#484bigmat18 wants to merge 1 commit into
bigmat18 wants to merge 1 commit into
Conversation
bashbaug
approved these changes
Sep 2, 2026
bashbaug
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Have you checked that the example you described on the issue generates the correct metadata now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #481
Description of Changes
Instead of guessing the image type from its dimensions, the Intercept Layer should explicitly query the exact memory object type by adding one more API call alongside the existing clGetImageInfo queries.
We can retrieve the type using clGetMemObjectInfo with the CL_MEM_TYPE flag, matching the existing coding style:
cl_mem_object_type imageType; errorCode |= dispatch().clGetMemObjectInfo( image, CL_MEM_TYPE, sizeof(imageType), &imageType, NULL );This guarantees that CL_MEM_OBJECT_IMAGE1D (and its array counterpart) remains exactly what the application requested, immune to driver quirks.
Testing Done
Tested on Windows