Fix build on kernels defaulting to gnu89 (pre-5.18) - #26
Open
knakazawa-ics wants to merge 1 commit into
Open
Conversation
Kernels before 5.18 compile modules with -std=gnu89, where the C99 for-loop declaration in intrepid_remove_eth_if() is a hard error, so current master does not build on e.g. Ubuntu 22.04 LTS (5.15). Hoist the declarations to the top of the function, which also satisfies -Wdeclaration-after-statement on newer kernels. Signed-off-by: Koki Nakazawa <knakazawa@intrepidcs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kernels before 5.18 compile modules with
-std=gnu89, where the C99 for-loopdeclaration in
intrepid_remove_eth_if()is a hard error, so current master does notbuild on e.g. Ubuntu 22.04 LTS (kernel 5.15):
Hoist the declarations to the top of the function, which also satisfies
-Wdeclaration-after-statement on newer kernels. Independent of, but required for,
testing #27 on such kernels.
A few pre-existing declaration-after-statement warnings remain in other functions
(SIOCSBAUDRATE handler, intrepid_dev_poll); those are warnings rather than errors and
are left untouched to keep this diff minimal.