test(sessions): add regression test for rows surviving failed refresh - #47
Closed
iscekic wants to merge 1 commit into
Closed
test(sessions): add regression test for rows surviving failed refresh#47iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
Surface: the web app (apps/web). On the sessions page, a failed refresh replaces the visible rows with the empty state, so a transient network error looks like "no sessions". Reproduce first on the live web app: load the page with rows present, then fail the refresh request. If the rows already survive a failed refresh, stop with the evidence and no code change. If they do not, keep the rows, show an inline retry that works, and declare the list empty only after a query completes successfully. Prove the fix live with a recording or screenshots in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
Changelog for users
Changelog for maintainers
list/searchdata on a failed refetch, and the render branch only shows the empty state after a query has data with zero rows.apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.test.ts) that renders the real component with real TanStack Query and asserts the rows stay rendered and neither the empty state nor the loading state appears afterinvalidateQueriesrejects.staleTime60s,retry1) from the providers.E2E proof
Recording of the verified flow (waits trimmed)
e1-refresh.webm.trim.mp4
Follow-ups (not changed here)