test(extension): regression test for session search focus retention - #48
Closed
iscekic wants to merge 1 commit into
Closed
test(extension): regression test for session search focus retention#48iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
Surface: the browser extension (apps/web-extension). In the extension's session list, the search field loses focus after every keystroke that updates the results, so typing a query takes several attempts. Reproduce first in a live extension build: open the session list, type three characters into the search field, and confirm whether focus survives. If focus already survives, stop with the evidence and no code change. If it does not, fix the root cause (do not remount the input on every result update) and prove the fix on the same live path with a recording or screenshots in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
Changelog for users
Changelog for maintainers
f,fi, andfixinto the "Search sessions" field and asserts focus survives while the debounced search results update (results change on the second and third keystrokes; the first is below the two-character search minimum).AgentsModeparent with a mocked agents provider and a stubbed tRPCcliSessionsV2.search, and flushes the 300 ms debounce with a real 350 ms timer — check that the real-timer flush is not flaky in CI.E2E proof