Add saved-tab question console mock - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
questions and answers about tabs that the user has visited, separately fromreadingdot-product-used-gpu=FalseReview boundary
This is intentionally stacked on #26 (
readable-vector-views). It reuses that readable multi-model vector backend instead of publishing the superseded binary-only backend from the earlier local branch. The bundled model is explicitly a deterministic test double, not an LLM, and the reducer is explicitly not XGBoost; both process boundaries are replaceable.The mock reports one vector index and two equivalent query paths: authoritative readable text and the rebuildable Float32 cache.
Verification
make clean testinnative/vector-indexsh bin/ci_browser_foundation.grease exercise-tab-qash bin/ci_browser_foundation.grease exercise-filesystem-viewsdetect_leaks=0; LeakSanitizer is unavailable in the ptraced workspace)