fix(resolution): #870 tone is not a property — benefit-vs-limitation contradiction FPs measured to zero - #879
Merged
Conversation
…contradiction FPs measured to zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
What this ships
One sentence inserted into the contradiction judge's rubric (
resolution/contradiction.py), after #558's antonymy carve-out: benefit-vs-limitation names DIFFERENT properties, two bodies acknowledging the same limitation AGREE about it, andcontradictsneeds incompatible values for one property — never opposite tone. Nothing else in the prompt moves.Plus the measurement that justified it: 6 new fixture pairs in
evals/contradictions/(benefit-limitation×4, the first mirroring the wild pair exactly including its internal "Sin embargo…" integration;evaluative-contradiction×2 as the wash-out guard), new headline metrics in the runner, and both 15-run stored arms.Measured (qwen3:8b, 15 runs/arm, production client settings, 18-pair fixture)
The baseline's class failure sits entirely in the wild-mirror pair: wrong 14 of 15 runs (9
contradictsat 0.95, 5uncertain). The failing shape is precise — both bodies acknowledge the SAME limitation, one in passing and one in depth, so the claims agree and only the tone opposes.Bonus, unlooked-for: antonym FP fell 0.32 → 0.00, closing the allowlist/denylist residual #558 recorded as unfixable at this model size. The treatment arm is 270/270 with every pair at stability 1.00.
TDD
test_the_rubric_separates_tone_from_propertywritten RED first, GREEN after the insert, and mutation-verified (sentence removed → test fails; byte-exact restore +__pycache__purge → green). Full suite 5653 passed / 1 skipped.Disclosures
review-021fa474aaa8c59fAPPROVED (medium risk, 1 reliability lens, zero corrections consumed). Round 1 caught a real deterministic defect — the README claimed the wild-mirror pair was "judged contradicts 14/15" where the stored artifact records 9 contradicts + 5 uncertain — fixed pre-capture on a fresh candidate. Round 2's one WARNING (the eval module's import-time drift guard fails loudly on a production rewording) declined as convention-consistent: it is the same guard shapeevals/adjudication/adjudication_prompts.pyhas carried since adjudicate: identical Event titles are recurring-meeting occurrences, not one entity (the judgment half of #776) #796, and its error message names the exact repair.finding_input_digestscovers member bytes + relation label only, so findings stored under the old rubric keep serving until members change orcontradictions --fresh. The adjudicate: a persisted verdict is served whatever rubric produced it, so a judgment fix does not reach a workspace that already ran #838 rubric-digest gate covers the adjudication store only. Pre-existing, documented in the prompt docstring.