Repository navigation
Check browser JavaScript with host-only ESLint - #16
Merged
Merged
Conversation
The printer page and docs-site scripts had no linter. Keep the checker on the build host so it never lands in a printer package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/www/js) and the docs-site script (website/assets/js).tools/eslint. It is not copied into printer packages.Test plan
npm ci --ignore-scripts --prefix tools/eslintbash tools/eslint-web-selftest.shbash tools/select-ci-validation-selftest.shreuse lintpolicy-validationruns the new ESLint step on this pull requestSummary by Sourcery
Add host-only ESLint validation for browser JavaScript and integrate it into CI without changing the printer-delivered scripts.
New Features:
Enhancements:
CI:
Documentation:
Tests: