Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #715. This strengthens the tests; it does not fix or change production behavior.
repr, including asyncio and Tornado's sleep functions, without pinning memory addresses.wait_incrementing(max=...)at and beyond the cap, for numeric andtimedeltalimits.idle_for: mock.ANYexpectations with exact totals. The existing wrappers actually use the default zero wait, so the successful retry cases now temporarily usewait_fixed(0.25)with only sleeping mocked out. The real retry loop accumulates 0.5s (sync) / 0.25s (async); stopping after the first attempt remains 0.Verification
On macOS, Python 3.10.20 (the minimum supported version), using the project's development dependencies and
poe allin a network-denied sandbox:-W.git diff --checkpassed.I also ran the full suite in separate temporary source copies, applying each mutation independently to both baseline (
3e58094) and updated tests:BaseRetrying.__repr__returns""wait_incrementingomitsmin(result, self.max)idle_forNone of these mutations are included in the commit. Tests without mutations pass. Other Python versions/platforms have not been run locally and remain for CI.
AI assistance: this contribution was investigated, authored and locally verified using Hermes Agent.