Reject negative wait_fixed intervals at construction - #719
Open
Pitchfork-and-Torch wants to merge 3 commits into
Open
Pitchfork-and-Torch wants to merge 3 commits into
Pitchfork-and-Torch wants to merge 3 commits into
Conversation
time.sleep rejects negatives with ValueError mid-retry; validate in wait_fixed.__init__ so callers get a clear error before any attempt.
Ruff format rejected the extra blank line after the test, which had been appended past the unittest main guard.
The module-level test tripped no-untyped-def on Python 3.14. It now returns None.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_fixed(-1)previously constructed successfully, then crashed mid-retry insidetime.sleepwithValueError: sleep length must be non-negative. Validatewait >= 0inwait_fixed.__init__so callers get a clear error before any attempt. Zero remains valid (same aswait_none).Test plan
test_wait_fixed_rejects_negativepasses