Skip to content

chore(ci): update performance runner image - #1370

Merged
jdx merged 1 commit into
mainfrom
chore/perf-image-fd66d9b
Sep 2, 2026
Merged

chore(ci): update performance runner image#1370
jdx merged 1 commit into
mainfrom
chore/perf-image-fd66d9b

Conversation

@jdx

@jdx jdx commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • pin performance workflows to the verified perf-runner image containing GitHub CLI
  • report perf-runner revision fd66d9b in job summaries
  • start a fresh TAK_RUNNER series for the rebuilt measurement environment

Image: ghcr.io/jdx/perf-runner@sha256:5263c143b12ce2234e7b0b21d3d6501c2ed05837b42937d0eaeaa191cd5c8e68

Validation

  • actionlint
  • git diff --check

AI-assisted — Tool: Codex; model: unavailable; version: unavailable.


Note

Low Risk
Workflow-only pinning of the self-hosted perf container; no application or auth changes, with the main effect being a deliberate break in comparability with measurements recorded under the old image until series baselines use the new label.

Overview
Bumps the pinned ghcr.io/jdx/perf-runner container digest for both perf (main measurements) and perf-pr (PR instruction-count compare) so CI runs on perf-runner@fd66d9b instead of the previous image.

The TAK_RUNNER env label gains an -img5263c143 suffix so tak can treat this image as a distinct runner environment, and the Runner metadata step logs the new revision and digest to match what jobs actually use.

Reviewed by Cursor Bugbot for commit ef3b0e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: e0d44c5d-96f2-4a88-b8e3-508052f48263

📥 Commits

Reviewing files that changed from the base of the PR and between cec178f and ef3b0e9.

📒 Files selected for processing (2)
  • .github/workflows/perf-pr.yml
  • .github/workflows/perf.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx merged commit 2bce819 into main Sep 2, 2026
12 checks passed
@jdx
jdx deleted the chore/perf-image-fd66d9b branch September 2, 2026 18:09
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
markdown ██▁ 380,430,322 → 380,374,693 -0.01% 63.05 → 63.28ms +0.36%
startup ▅▁█ 944,250 → 950,986 +0.71% 1.17 → 1.15ms -1.27%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

Shadow comparison

Parsing mise use -g node@20 against a shadow of mise's committed spec.
Reported, not gated: the shadow grows as the derive learns to express more, so
what to watch is the ratio rather than either column.

framework stripped binary, bytes
usage 1344728
bpaf 2493216
clap 3101656
framework instructions, cold parse vs usage
usage 8530
clap 6315758 740x
bpaf 21909029 2568x
                                              min       p01       p10    median
usage-rs: argv -> struct                     1237      1273      1288      1296  ns
clap: build tree + parse -> struct        1781728   1782748   1788400   1798056  ns
bpaf: build parser + parse -> struct      5621528   5621528   5664860   5748769  ns

usage: argv -> struct                            1225 ns      1.22 µs
clap: build tree + parse -> struct            1821684 ns   1821.68 µs
clap: parse -> struct, tree reused              72380 ns     72.38 µs
clap: build tree only                         1040220 ns   1040.22 µs

ef3b0e99afff vs cec178fe25db · measured on the runner, not pushed to the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant