refactor(core): remove legacy instrumentation and finalize adapter architecture (#15) - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Summary
Removes remaining legacy instrumentation, wrapper modules, and compatibility infrastructure across itchy.nvim, completing the migration to the unified adapter/event architecture.
Changes
lua/itchy/adapters/legacy.lua,lua/itchy/wrappers/, andtests/legacy_adapter_spec.lua.dosbatchruntime and deleted its orphaned test fixturetests/test_files/cmd.bat.adapters.resolvenow fails explicitly when a runtime specifies an unknown or missing adapter.lua/itchy/utils.lua:should_filter_line,get_wrapped_code,parse_line_output,parse_error_output,process_output_text,process_output,process_error,apply_extmarks,is_headless.Snacks.debug.run()without adapter resolution or premature runtime loading.snacks_debugnamespace clearing.{ enabled = false }tables.#\d+issue numbers and migration/transitional phrasing from production comments.README.mdto document adapter-based custom runtimes, removing wrapper hack explanations. Left generated vimdocs indoc/untouched.tests/adapters_spec.luacovering strict registry resolution, repository audits against legacy imports/issue references, and Lua/Snacks integration semantics.Verification
Ran the complete test suite:
Result: 216 test cases passed across 17 test groups (0 fails, 0 notes).