Skip to content

Fix goal review verification guidance #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuawheelock merged 1 commit into from
Aug 25, 2026
Merged

Fix goal review verification guidance #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- **Goal review verification**: Managed review instructions now discover and run project-supported verification instead of assuming a specific package manager or ecosystem, preventing unrelated review rejections in nonmatching projects.

## [3.21.0] - 2026-08-18

### Added
Expand Down
17 changes: 10 additions & 7 deletions assets/skills/review-jumbo-goal/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,16 @@ For each category in the review output:

If ANY entity constraint is violated: add the issues to the feedback list.

### 6. Run Tests
### 6. Run Applicable Verification

```bash
npm test
```
Discover the project's verification commands from its repository instructions, build
manifests, and CI configuration. Run the tests and other checks that apply to the changed
scope using the project's own tooling.

All tests must pass. If tests fail: add the issues to the feedback list.
Record failures from applicable verification in the feedback list. Do not require
verification commands that the project does not define as applicable. If the project
defines no automated verification for the changed scope, record that fact as review
evidence rather than a failure.

### 7. Qualify or Re-Review

Expand All @@ -87,8 +90,8 @@ jumbo goal reject --id <goal-id> --audit-findings <list of issues>

## Rules

1. **Never approve with unresolved failures.** Every criterion, invariant, and test must pass before approving.
1. **Never approve with unresolved failures.** Every criterion, invariant, and applicable verification must pass before approving.
2. **Never skip entity categories.** Review output includes entities for a reason — each was registered during refinement as essential context.
3. **Always run tests.** Implementation without passing tests is incomplete.
3. **Always run applicable verification.** Use the project's defined tools and commands; do not assume a package manager or ecosystem.
4. **Document issues clearly.** When rejecting a goal, provide detailed feedback for each failure.
5. **Read the code, don't assume.** Verify each criterion by reading actual implementation, not by recalling what you wrote.
Loading