fix: wire the system service into controller-v2 - #2614
Closed
Charlesthebird wants to merge 1 commit into
Closed
Conversation
The inventory wiring lived in the legacy controller application, deleted by #2595, and controller-v2 never carried it over. `grpcserver.New` then falls back to a system service constructed with no options, so it holds no Kubernetes client and every namespace read returns an internal error. The UI reads templates one namespace at a time, so the namespace list is an input to that read rather than a detail beside it: the agents page reports the failure as "Could not load agents — internal server error" and lists nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
Charlesthebird
force-pushed
the
Charlesthebird/wireSystemService
branch
from
August 28, 2026 02:48
0e00067 to
86677c1
Compare
Charlesthebird
marked this pull request as ready for review
August 28, 2026 02:49
Charlesthebird
marked this pull request as draft
August 28, 2026 02:51
Collaborator
Author
|
Superseded by #2602, which wires the same 🤖 written by Claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 written by Claude (start)
Changelog
The Agents page loads again.
controller-v2now constructs the system service with its Kubernetes client and substrate inventory, soListNamespacessucceeds instead of returningINTERNALon every call.Why it was broken
systemservice.WithInventoryhad no caller: the wiring lived ingo/core/pkg/app/app.go, deleted by #2595, andcontroller-v2never carried it over.grpcserver.Newthen falls back tosystemservice.NewService()with no options, and every namespace read stops at thekubeClient == nilguard. The UI reads templates one namespace at a time, so the agents list reports that asCould not load agents — internal server error.Two gaps from the same deletion are not fixed here and are described in #2613:
ModelService,ToolService,PromptTemplateService,FeedbackServiceandMemoryServiceare still unregistered, andmanagerSchemestill omitsatev1alpha1, whichGetSubstrateStatusneeds.Testing
scripts/setup-cluster/setup-cluster.sh, thenkubectl -n kagent port-forward svc/kagent-ui 8080:8080.localhost:8080/agents— the list renders the harness/template pair the script created, with no error banner.Closes #2613
🤖 written by Claude (end)