Add backup & restore actions for Milvus - #673
Merged
Merged
Conversation
Adds the Backups action group (Configure Backup, Instant Backup, Restore) to the Milvus ResourceEditor and the KubeStash Backup page to the Milvus kubedb ResourceOutline, matching the other backup-capable databases. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
added a commit
that referenced
this pull request
Sep 9, 2026
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milvus was missing the backup/restore UI wiring that other backup-capable databases already have.
hub/resourceeditors/kubedb.com/v1alpha2/milvuses.yaml— add theBackupsaction group: Configure Backup (edit-self-backupconfiguration), Instant Backup (create-instant-backup), Restore (create-restoresession).hub/resourceoutlines/kubedb.com/v1alpha2/kubedb/milvuses.yaml— add theBackuppage renderingcore.kubestash.com-v1alpha1-kubedb-backup, gated onopscenter-backup: kubestash.Autoscaling needed no change: the
Autoscalingaction group (Compute + Storage) and themilvusautoscalerseditor/table definition were already present and match the other databases.Milvus is already listed in the KubeStash
backupconfigurations/restoresessionsresource descriptors, so no descriptor change was needed.Verified with
check-edge-label,resource-fmt(both clean, no further diff) andgo build ./....