Skip to content

Add script to update semconv version if OTel is updated #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsimansk wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −0
Open

Add script to update semconv version if OTel is updated #3385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions hack/update-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,42 @@ set -o pipefail
source $(dirname "$0")/../vendor/knative.dev/hack/library.sh

go_update_deps "$@"

# Sync semconv imports with the resolved OTEL module.
log.step "Syncing semconv imports"
OTEL_VERSION=$(go list -m -f '{{.Version}}' go.opentelemetry.io/otel 2>/dev/null || true)
if [ -n "$OTEL_VERSION" ]; then
group "Detected go.opentelemetry.io/otel ${OTEL_VERSION}"

# Semconv versions are package directories inside the OTEL module.
OTEL_DIR=$(GOFLAGS=-mod=mod go list -m -f '{{.Dir}}' go.opentelemetry.io/otel 2>/dev/null || true)
SEMCONV_VERSION=""
if [ -d "${OTEL_DIR}/semconv" ]; then
SEMCONV_VERSION=$(find "${OTEL_DIR}/semconv" -mindepth 1 -maxdepth 1 \
-type d -name 'v[0-9]*.[0-9]*.[0-9]*' -exec basename {} \; | sort -V | tail -1)
fi

if [ -n "$SEMCONV_VERSION" ]; then
group "Updating semconv imports to ${SEMCONV_VERSION}"
mapfile -t SEMCONV_FILES < <(
find observability -type f -name '*.go' -exec \
grep -lE 'go\.opentelemetry\.io/otel/semconv/v[0-9]+\.[0-9]+\.[0-9]+' {} + || true
)
SEMCONV_IMPORTS_CHANGED=false
for file in "${SEMCONV_FILES[@]}"; do
current_versions=$(grep -oE \
'go\.opentelemetry\.io/otel/semconv/v[0-9]+\.[0-9]+\.[0-9]+' "$file" | \
sed -E 's#.*(v[0-9]+\.[0-9]+\.[0-9]+)$#\1#' | sort -u)
if [ "$current_versions" != "$SEMCONV_VERSION" ]; then
group " ${file}"
sed -i -E "s|(go.opentelemetry.io/otel/semconv/)v[0-9]+\.[0-9]+\.[0-9]+|\1$SEMCONV_VERSION|g" "$file"
SEMCONV_IMPORTS_CHANGED=true
fi
done

[ "$SEMCONV_IMPORTS_CHANGED" = true ] && go_update_deps

else
group "Could not determine semconv version, skipping"
fi
fi
Loading