Skip to content

fix(agents): install Codex skills to .agents/skills - #82

Open
knoxgraeme wants to merge 1 commit into
mainfrom
claude/elegant-curie-ujcc9q
Open

knoxgraeme wants to merge 1 commit into
mainfrom
claude/elegant-curie-ujcc9q

Conversation

@knoxgraeme

Copy link
Copy Markdown
Owner

Summary

AGENT_CONFIGS for Codex pointed skill installs at .codex/skills, but Codex only scans .agents/skills (repo scope, walked up to the repo root) and $HOME/.agents/skills (user scope) — .codex is config-only (config.toml). Skills installed with skillfish add --agent Codex landed in a directory Codex never reads: the install reported success, but the skill was invisible to Codex.

Changed the Codex entry's dir from .codex/skills to .agents/skills. homePaths/cwdPaths are untouched — they're still used purely for detecting that Codex is present (.codex/config.json, .codex/settings.json, .codex), which is unaffected by this change. No globalDir override is needed: getAgentSkillDir joins dir onto the home directory for global installs, so this alone resolves to ~/.agents/skills for global scope and <project>/.agents/skills for project scope, matching both locations from the issue.

Not included: a migration/warning path for skills previously installed under the old .codex/skills location. That's optional follow-up scope beyond the root-cause fix and is worth tracking separately.

Related Issue

Fixes #81

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • New agent support (adds support for a new AI agent)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the project's style guidelines
  • I have added tests that prove my fix works
  • All new and existing tests pass (npm test)
  • The build succeeds (npm run build)
  • I have updated documentation if needed

Testing

  • npm run typecheck, npm run lint, npm run build, and npm test all pass (250/250 tests).
  • Added a regression test in src/__tests__/agents.test.ts asserting the Codex config's dir is .agents/skills.

Generated by Claude Code

Codex discovers skills from .agents/skills (repo/user scope), not
.codex/skills — .codex is config-only. Skills installed via `skillfish
add --agent Codex` were landing in a directory Codex never scans, so
installs reported success but the skill was invisible to Codex.

Fixes #81
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex skills install to .codex/skills, but Codex only scans .agents/skills

2 participants