Repository navigation
fix(agents): install Codex skills to .agents/skills - #82
Open
knoxgraeme wants to merge 1 commit into
Open
knoxgraeme wants to merge 1 commit into
knoxgraeme wants to merge 1 commit into
Conversation
Codex discovers skills from .agents/skills (repo/user scope), not .codex/skills — .codex is config-only. Skills installed via `skillfish add --agent Codex` were landing in a directory Codex never scans, so installs reported success but the skill was invisible to Codex. Fixes #81
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_CONFIGSfor Codex pointed skill installs at.codex/skills, but Codex only scans.agents/skills(repo scope, walked up to the repo root) and$HOME/.agents/skills(user scope) —.codexis config-only (config.toml). Skills installed withskillfish add --agent Codexlanded in a directory Codex never reads: the install reported success, but the skill was invisible to Codex.Changed the Codex entry's
dirfrom.codex/skillsto.agents/skills.homePaths/cwdPathsare untouched — they're still used purely for detecting that Codex is present (.codex/config.json,.codex/settings.json,.codex), which is unaffected by this change. NoglobalDiroverride is needed:getAgentSkillDirjoinsdironto the home directory for global installs, so this alone resolves to~/.agents/skillsfor global scope and<project>/.agents/skillsfor project scope, matching both locations from the issue.Not included: a migration/warning path for skills previously installed under the old
.codex/skillslocation. That's optional follow-up scope beyond the root-cause fix and is worth tracking separately.Related Issue
Fixes #81
Type of Change
Checklist
npm test)npm run build)Testing
npm run typecheck,npm run lint,npm run build, andnpm testall pass (250/250 tests).src/__tests__/agents.test.tsasserting the Codex config'sdiris.agents/skills.Generated by Claude Code