Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1617.
Fix for Ring Wired Video Doorbell Pro / Video Doorbell Pro 2 distorted, crackling, fragmented, or missing audio in Apple Home/HomeKit through Scrypted.
Ring Wired Video Doorbell Pro / Video Doorbell Pro 2 can select Opus even when PCMU is listed first in the WebRTC offer. In HomeKit this produces heavily fragmented, distorted, or missing incoming audio. Excluding Opus from the Ring doorbell source offer makes the device select its stable 8 kHz G.711 PCMU stream.
This change:
@scrypted/ringwith typeDoorbell;Validation:
lpd_v4);git diff --checkpasses.The tested custom package was WebRTC
0.2.89-phil.4, used with HomeKit audio transcoding enabled.