Repository navigation
docs: QA cuts the release, not a repo maintainer - #171
Merged
Merged
Conversation
The runbook and CONTRIBUTING both said a maintainer dispatches the Release workflow. QA owns that step: they validate merged `main` against staging and then run the release themselves. Whoever reviews spec-sync PRs should still know the step, since a red release usually comes back to them to diagnose. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The design documentation still contradicts the updated QA ownership model.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates release documentation to clarify that QA validates staging and dispatches releases.
Changes:
- Assigns release ownership to QA.
- Retains release workflow and failure-diagnosis guidance.
| File | Description |
|---|---|
docs/spec-sync-runbook.md |
Clarifies QA’s release responsibilities. |
CONTRIBUTING.md |
Updates contributor-facing release ownership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…torical release.yml's own header told the reader a maintainer runs it — the one place QA actually reads before dispatching. The Stainless-exit design doc is a dated decision record (Approved 2026-07-07), so its prose is left as written rather than retrofitted; a standing note in its header points at CONTRIBUTING and the runbook as authoritative and names the known divergences, which include the never-wired production-spec release gate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
CONTRIBUTING omits the required production rollout before QA dispatches the release.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
…fore dispatch' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runbook and CONTRIBUTING both said a maintainer dispatches the Release workflow. QA owns that step — they validate merged
mainagainst staging and then cut the release themselves.Kept the mechanics in the runbook rather than dropping them: whoever reviews spec-sync PRs still needs to recognise a red release (gate 0 runs the e2e suite against the live production API), since diagnosing it comes back to them.