Skip to content

feat: replace EOL netcoreapp3.1 target with net8.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanderson-ld merged 3 commits into from
Sep 22, 2026
Merged

feat: replace EOL netcoreapp3.1 target with net8.0 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02a5cf2
feat: replace EOL netcoreapp3.1 target with net8.0
tanderson-ld Sep 21, 2026
4698802
fix: match Microsoft.Extensions.Logging.Abstractions to the net8.0 fr…
tanderson-ld Sep 22, 2026
bb92882
Merge branch 'main' into tanderson/sdk-3131-drop-netcoreapp31
tanderson-ld Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ To run all unit tests, for all targets:
dotnet test test/LaunchDarkly.Logging.Tests
```

Or, to run tests only for the .NET Standard 2.0 target (using the .NET Core 2.1 runtime):
Or, to run tests for only one target framework:

```
dotnet test test/LaunchDarkly.Logging.Tests -f netcoreapp2.1
dotnet test test/LaunchDarkly.Logging.Tests -f net8.0
```
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ For more information and examples, see the [API documentation](https://launchdar
This version of the library is built for the following targets:

* .NET Framework 4.6.2: runs on .NET Framework 4.6.2 and above.
* .NET Core 3.1: runs on .NET Core 3.x, or .NET 6.0+. This target provides an adapter to the standard .NET Core logging framework, `Logs.CoreLogging`, which is not available in .NET Framework except as a separate package.
* .NET 8.0: runs on .NET 8.0 and above. This target provides an adapter to the standard .NET logging framework, `Logs.CoreLogging`, which is not available in the other targets except as a separate package.
* .NET Standard 2.0: runs on application platforms that are neither of the above, such as Xamarin, or within a library that is targeted to .NET Standard 2.x.

The .NET build tools should automatically load the most appropriate build of the library for whatever platform your application or library is targeted to.
Expand Down
6 changes: 3 additions & 3 deletions src/LaunchDarkly.Logging/LaunchDarkly.Logging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
an environment variable is that we want to be able to run CI tests using .NET
SDKs that may not support all of these target frameworks.
-->
<BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;netcoreapp3.1;net462</BuildFrameworks>
<BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net8.0;net462</BuildFrameworks>
<TargetFrameworks>$(BUILDFRAMEWORKS)</TargetFrameworks>
<DebugType>portable</DebugType>
<AssemblyName>LaunchDarkly.Logging</AssemblyName>
Expand All @@ -29,8 +29,8 @@
<WarningsAsErrors>1570,1571,1572,1573,1574,1580,1581,1584,1591,1710,1711,1712</WarningsAsErrors>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.0" />
<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
Comment thread
tanderson-ld marked this conversation as resolved.
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.3" />
</ItemGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
Expand Down
4 changes: 2 additions & 2 deletions src/LaunchDarkly.Logging/Logs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ public static SimpleLogging ToMethod(Action<string> writeLineMethod) =>
/// </summary>
/// <remarks>
/// <para>
/// This method is only available when your target framework is .NET Core or .NET 6.0+. It causes
/// This method is only available when your target framework is .NET 8.0 or later. It causes
/// the <c>LaunchDarkly.Logging</c> APIs to delegate to the <c>Microsoft.Extensions.Logging</c>
/// framework. The <c>ILoggingFactory</c> is the main configuration object for
/// <c>Microsoft.Extensions.Logging</c>; application code can construct it programmatically,
/// or can obtain it by dependency injection. For more information, see
/// <see href="https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-3.1">Logging
/// <see href="https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-8.0">Logging
/// in .NET Core and ASP.NET Core</see>.
/// </para>
/// <para>
Expand Down
2 changes: 1 addition & 1 deletion test/LaunchDarkly.Logging.Tests/LaunchDarkly.Logging.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PackageReference Include="xunit.runner.console" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" />
<PackageReference Include="JunitXml.TestLogger" Version="3.0.114" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.1" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading